Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create subgraph fetch command #117

Merged
merged 10 commits into from
Dec 16, 2020
Merged

Create subgraph fetch command #117

merged 10 commits into from
Dec 16, 2020

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Dec 9, 2020 •
edited
Loading

This PR adds the rover subgraph fetch command to fetch SDL of a federated graph's implementing service from studio

Fun facts

  • This command errors when being run on a non-federated graph (yay, readable errors!)
  • This command errors when --service-name isn't found, and responds with a list of available services to query (woo)

@JakeDawkins JakeDawkins changed the title Create subgraph fetch command [WIP] Create subgraph fetch command Dec 9, 2020
@JakeDawkins JakeDawkins mentioned this pull request Dec 11, 2020
Closed
@JakeDawkins JakeDawkins changed the title [WIP] Create subgraph fetch command Create subgraph fetch command Dec 14, 2020
lrlna
lrlna approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @JakeDawkins! A few minor comments, all non-blocking.

crates/rover-client/src/query/partial/fetch.rs Outdated Show resolved Hide resolved
crates/rover-client/src/query/partial/fetch.rs Outdated Show resolved Hide resolved
crates/rover-client/src/query/partial/mod.rs Outdated Show resolved Hide resolved
crates/rover-client/src/query/partial/fetch.rs Outdated Show resolved Hide resolved
@JakeDawkins JakeDawkins merged commit 9ad331a into main Dec 16, 2020
@JakeDawkins JakeDawkins deleted the jake/sub-fetch branch December 16, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper left review comments

@lrlna lrlna lrlna approved these changes

@ashleygwilliams ashleygwilliams Awaiting requested review from ashleygwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeDawkins @lrlna @EverlastingBugstopper